Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend jaeger results #47

Merged
merged 8 commits into from
Jun 1, 2021
Merged

Conversation

aksdb
Copy link
Contributor

@aksdb aksdb commented Mar 23, 2021

The previous implementation had one problem and two shortcomings I hope to have fixed with this PR:

  1. In the error case, "200" was stored as http.status_code. I now call c.Error(err) to properly populate the status code.
  2. The error message was not added to the span. This is now done, even with special support for echo.HTTPError so its message can be easily tracked.
  3. The componentName was private and could not be changed. It is public now.

Only downside: I had to increase the required Go version to 1.13, since I use error-unwrapping.

@aksdb
Copy link
Contributor Author

aksdb commented Mar 23, 2021

This should fix #32.

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #47 (5795e46) into master (4026d23) will increase coverage by 1.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   54.42%   55.62%   +1.20%     
==========================================
  Files           8        8              
  Lines         441      453      +12     
==========================================
+ Hits          240      252      +12     
  Misses        182      182              
  Partials       19       19              
Impacted Files Coverage Δ
jaegertracing/jaegertracing.go 46.77% <100.00%> (+5.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4026d23...5795e46. Read the comment docs.

@aldas aldas merged commit 063b8fd into labstack:master Jun 1, 2021
@aldas aldas mentioned this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants