Prometheus middleware should not call c.Error() as it causes double error logging #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aldas
commented
Jun 1, 2021
aldas
commented
- Prometheus middleware should not call c.Error() as it causes double error logging.
- Handle status code properly when next returns an error
…rror logging. Handle status code properly when next returns an error
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 55.62% 55.77% +0.14%
==========================================
Files 8 8
Lines 453 459 +6
==========================================
+ Hits 252 256 +4
- Misses 182 183 +1
- Partials 19 20 +1
Continue to review full report at Codecov.
|
This was referenced Jun 1, 2021
FloThinksPi
pushed a commit
to cloudfoundry/go-cf-api
that referenced
this pull request
Dec 8, 2021
We ran into a bug where the Prometheus middleware was calling c.Error and causing double entry into our error handler function. This was fixed by labstack/echo-contrib#56 which is part of v0.11.0 so upgrading fixes it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.