Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to echo/v4 #9

Merged
merged 3 commits into from Feb 20, 2019
Merged

Update to echo/v4 #9

merged 3 commits into from Feb 20, 2019

Conversation

im-kulikov
Copy link
Contributor

@im-kulikov im-kulikov commented Feb 17, 2019

  • add go modules
  • fix unhandled errors

Fix #8

- add go modules
- fix unhandled errors
- github.com/gorilla/context v1.1.1
- github.com/gorilla/sessions v1.1.3
@codecov
Copy link

codecov bot commented Feb 17, 2019

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files           2        2           
  Lines          39       39           
=======================================
  Hits           37       37           
  Misses          1        1           
  Partials        1        1
Impacted Files Coverage Δ
session/session.go 100% <ø> (ø) ⬆️
casbin/casbin.go 90% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aaa9fa...e2ff106. Read the comment docs.

@im-kulikov
Copy link
Contributor Author

Fixes #8

@im-kulikov
Copy link
Contributor Author

@vishr @alexaandru any thoughts?

@alexaandru
Copy link

Looks good to me @im-kulikov

@vishr vishr merged commit 7fa08ff into labstack:master Feb 20, 2019
@im-kulikov im-kulikov deleted the fix/echo-v4-modules branch February 20, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use with echo/v4 (Go Modules)
3 participants