dont return 400 for empty bodies (#1410)

* dont return 400 for empty bodies * remove test for missing contentlength 0
labstack · Sep 30, 2019 · b129098 · b129098
1 parent 81a6608
commit b129098
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/bind.go b/bind.go
@@ -43,15 +43,11 @@ func (b *DefaultBinder) Bind(i interface{}, c Context) (err error) {
 	if err := b.bindData(i, params, "param"); err != nil {
 		return NewHTTPError(http.StatusBadRequest, err.Error()).SetInternal(err)
 	}
-
+	if err = b.bindData(i, c.QueryParams(), "query"); err != nil {
+		return NewHTTPError(http.StatusBadRequest, err.Error()).SetInternal(err)
+	}
 	if req.ContentLength == 0 {
-		if req.Method == http.MethodGet || req.Method == http.MethodDelete {
-			if err = b.bindData(i, c.QueryParams(), "query"); err != nil {
-				return NewHTTPError(http.StatusBadRequest, err.Error()).SetInternal(err)
-			}
-			return
-		}
-		return NewHTTPError(http.StatusBadRequest, "Request body can't be empty")
+		return
 	}
 	ctype := req.Header.Get(HeaderContentType)
 	switch {

diff --git a/bind_test.go b/bind_test.go
@@ -147,7 +147,6 @@ func TestBindForm(t *testing.T) {
 	assert := assert.New(t)
 
 	testBindOkay(assert, strings.NewReader(userForm), MIMEApplicationForm)
-	testBindError(assert, nil, MIMEApplicationForm, nil)
 	e := New()
 	req := httptest.NewRequest(http.MethodPost, "/", strings.NewReader(userForm))
 	rec := httptest.NewRecorder()