Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master is broken with Go 1.7.4 #1129

Closed
3 tasks done
ghost opened this issue May 9, 2018 · 3 comments
Closed
3 tasks done

master is broken with Go 1.7.4 #1129

ghost opened this issue May 9, 2018 · 3 comments

Comments

@ghost
Copy link

ghost commented May 9, 2018

Issue Description

Pulling master with go get -u github.com/labstack/echo brings up multiple errors due to features not available on Go 1.7.4 being used.

Checklist

  • Dependencies installed
  • No typos
  • Searched existing issues and docs

Expected behaviour

Echo to build without failure

Actual behaviour

../go/src/github.com/labstack/echo/bind.go:47: ute.Field undefined (type *json.UnmarshalTypeError has no field or method Field)
../go/src/github.com/labstack/echo/echo.go:448: undefined: url.PathUnescape
../go/src/github.com/labstack/echo/echo.go:684: e.TLSServer.Close undefined (type *http.Server has no field or method Close)
../go/src/github.com/labstack/echo/echo.go:687: e.Server.Close undefined (type *http.Server has no field or method Close)
../go/src/github.com/labstack/echo/echo.go:693: e.TLSServer.Shutdown undefined (type *http.Server has no field or method Shutdown)
../go/src/github.com/labstack/echo/echo.go:696: e.Server.Shutdown undefined (type *http.Server has no field or method Shutdown)

Steps to reproduce

  1. Install go-1.7 from Debian Stretch repos
  2. Pull with: go get -u github.com/labstack/echo

Working code to debug

nil.

Version/commit

master (commit d36ff72)

@ferhatelmas
Copy link
Contributor

@mission712 #1100 try vendoring.

@vishr
Copy link
Member

vishr commented May 9, 2018

@mission712 We officially don't support go 1.7 & 1.8 https://github.com/labstack/echo/blob/master/.travis.yml#L2

@vishr vishr closed this as completed May 10, 2018
@ghost
Copy link
Author

ghost commented May 12, 2018

@vishr https://echo.labstack.com/guide/installation claims otherwise, though. Consider updating the page.
EDIT: Check out labstack/echox#70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants