Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean old Go versions #1100

Merged
merged 2 commits into from Apr 3, 2018

Conversation

Projects
None yet
2 participants
@alexandrestein
Copy link

commented Apr 3, 2018

Because Travis checks only from Go 1.9; we can maybe clean the specific builds.

@codecov

This comment has been minimized.

Copy link

commented Apr 3, 2018

Codecov Report

Merging #1100 into master will increase coverage by 0.08%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1100      +/-   ##
==========================================
+ Coverage   81.06%   81.14%   +0.08%     
==========================================
  Files          27       25       -2     
  Lines        1901     1899       -2     
==========================================
  Hits         1541     1541              
+ Misses        253      250       -3     
- Partials      107      108       +1
Impacted Files Coverage Δ
middleware/static.go 56.45% <100%> (ø) ⬆️
echo.go 87.94% <55.55%> (-1.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60f88a7...dedf0db. Read the comment docs.

echo.go Outdated
@@ -729,6 +749,11 @@ func handlerName(h HandlerFunc) string {
return t.String()
}

// PathUnescape is wraps `url.PathUnescape`
func PathUnescape(s string) (string, error) {

This comment has been minimized.

Copy link
@vishr

vishr Apr 3, 2018

Member

We can drop this function and directly use url.PathUnescape - wherever it is being used.

@vishr
Copy link
Member

left a comment

Please see inline comments

@vishr

vishr approved these changes Apr 3, 2018

@vishr vishr merged commit 37f1a47 into labstack:master Apr 3, 2018

2 of 3 checks passed

codecov/patch 60% of diff hit (target 81.06%)
Details
codecov/project 81.14% (+0.08%) compared to 60f88a7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vishr

This comment has been minimized.

Copy link
Member

commented Apr 3, 2018

@alexandrestein again, thanks for your contribution 🎉

@alexandrestein alexandrestein deleted the alexandrestein:cleanBeforeGo1.9 branch Apr 24, 2018

@ferhatelmas ferhatelmas referenced this pull request May 9, 2018

Closed

master is broken with Go 1.7.4 #1129

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.