Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group static handler bypass group defined middlewares #701

Closed
mtpc opened this issue Oct 30, 2016 · 2 comments
Closed

Group static handler bypass group defined middlewares #701

mtpc opened this issue Oct 30, 2016 · 2 comments
Assignees
@vishr
Labels
bug

Comments

@mtpc
Copy link

mtpc commented Oct 30, 2016

Yet another issue in v3:

coming from

echo/group.go

Line 88 in 796df51

g.echo.Static(g.prefix+prefix, root)
which doesn't follow the group middleware chain since it uses the base instance's Static method
@vishr vishr self-assigned this Oct 30, 2016
@vishr vishr added the bug label Oct 30, 2016
vishr added a commit that referenced this issue Oct 30, 2016
@vishr
fixed #701
891d851 
Signed-off-by: Vishal Rana <vr@labstack.com>
@vishr
Copy link
Member

vishr commented Oct 30, 2016

Thanks for reporting, please verify the fix.

@vishr vishr closed this as completed Oct 30, 2016
@mtpc
Copy link
Author

mtpc commented Oct 31, 2016

Yep, works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishr vishr

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vishr @mtpc