Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #1086 #1091

Merged
merged 1 commit into from Mar 16, 2018
Merged

fix issue #1086 #1091

merged 1 commit into from Mar 16, 2018

Conversation

JReuling
Copy link

Fixes issue #1086
Path is currently set before premiddleware is ran, resulting in a failure of the new test.

@codecov
Copy link

codecov bot commented Mar 16, 2018

Codecov Report

Merging #1091 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
+ Coverage   80.86%   80.89%   +0.03%     
==========================================
  Files          27       27              
  Lines        1892     1895       +3     
==========================================
+ Hits         1530     1533       +3     
  Misses        254      254              
  Partials      108      108
Impacted Files Coverage Δ
echo.go 88.84% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d79727c...e84b2d7. Read the comment docs.

@vishr vishr merged commit ee32e3e into labstack:master Mar 16, 2018
@vishr
Copy link
Member

vishr commented Mar 16, 2018

@JReuling thanks for your contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants