Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Router#Find panic an infinite loop #1661

Merged

Conversation

pafuent
Copy link
Contributor

@pafuent pafuent commented Oct 28, 2020

Before this fix, Router#Find panics or enters in an infinite loop when the context params values were set to a number less than the max number of params supported by the Router.
This fix #1655

Before this fix, Router#Find panics or enters in an infinite loop when
the context params values were set to a number less than the max number
of params supported by the Router.
@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #1661 (53653b3) into master (4422e3b) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1661      +/-   ##
==========================================
+ Coverage   85.19%   85.26%   +0.06%     
==========================================
  Files          29       29              
  Lines        1986     1995       +9     
==========================================
+ Hits         1692     1701       +9     
  Misses        186      186              
  Partials      108      108              
Impacted Files Coverage Δ
context.go 87.19% <100.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4422e3b...53653b3. Read the comment docs.

@fanpei91
Copy link

fanpei91 commented Nov 4, 2020

Good done! I am looking forward to this being merged.

@lammel
Copy link
Contributor

lammel commented Dec 12, 2020

@pafuent Please rebase, I'll merge then.

@lammel
Copy link
Contributor

lammel commented Dec 15, 2020

Referencing #1689 as it might be related.

@pafuent
Copy link
Contributor Author

pafuent commented Dec 16, 2020

@lammel rebased

@lammel lammel merged commit 03ce9b2 into labstack:master Dec 16, 2020
@lammel lammel self-requested a review December 16, 2020 09:11
@aldas
Copy link
Contributor

aldas commented Dec 16, 2020

@lammel @pafuent there is something wrong with this merge. I do not understand why

echo/echo.go

Line 503 in ea31edb

get(prefix, h)
is now there. Tests fail for static now

these are changes between last working merge to master and current master 4422e3b...master

and something went wrong with 4422e3b...0482cb3

@aldas
Copy link
Contributor

aldas commented Dec 16, 2020

This seems to be problem for these tests

f72eaa4#diff-996f64128c7fffe6cc8254ea4e1ac3c5693956f86ab5c8952e525083cf14ca27L26

but

echo/echo.go

Line 503 in ea31edb

get(prefix, h)

is also strange. get() is now executed twice

@pafuent
Copy link
Contributor Author

pafuent commented Dec 17, 2020

@aldas Please check my comment here #1674 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

looping/panic router.go#Find when set param to context
4 participants