Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: basic auth invalid base64 string #2191

Merged

Conversation

wellingguzman
Copy link
Contributor

fixes #2170

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #2191 (9bd1c7a) into master (d5f8837) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2191      +/-   ##
==========================================
+ Coverage   92.20%   92.26%   +0.06%     
==========================================
  Files          37       37              
  Lines        3090     3090              
==========================================
+ Hits         2849     2851       +2     
+ Misses        151      150       -1     
+ Partials       90       89       -1     
Impacted Files Coverage Δ
middleware/basic_auth.go 71.87% <100.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5f8837...9bd1c7a. Read the comment docs.

aldas
aldas approved these changes May 26, 2022
Copy link
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldas aldas merged commit b0453b9 into labstack:master May 27, 2022
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BasicAuth middleware returns 500 InternalServerError on invalid base64 strings
3 participants