Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add supprt for go1.20 http.rwUnwrapper #2425

Merged
merged 1 commit into from Apr 6, 2023
Merged

Conversation

imxyb
Copy link
Contributor

@imxyb imxyb commented Mar 28, 2023

Support ResponseController for Go 1.20

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f22ba67) 92.87% compared to head (f2019e7) 92.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2425   +/-   ##
=======================================
  Coverage   92.87%   92.87%           
=======================================
  Files          39       39           
  Lines        4519     4521    +2     
=======================================
+ Hits         4197     4199    +2     
  Misses        234      234           
  Partials       88       88           
Impacted Files Coverage Δ
response.go 86.36% <100.00%> (+0.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aldas
Copy link
Contributor

aldas commented Mar 31, 2023

@imxyb this looks OK but could you add one test for it.

@imxyb
Copy link
Contributor Author

imxyb commented Apr 3, 2023

@imxyb this looks OK but could you add one test for it.

done

Copy link
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldas aldas merged commit a7802ea into labstack:master Apr 6, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants