Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not use global timeNow variables #2477

Merged
merged 1 commit into from Jul 11, 2023
Merged

Conversation

aldas
Copy link
Contributor

@aldas aldas commented Jul 11, 2023

fixes #2476 . This is problematic in tests as this is only place where that global now variable could be mutated

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: -0.07 ⚠️

Comparison is base (42f07ed) 92.87% compared to head (ec2e034) 92.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2477      +/-   ##
==========================================
- Coverage   92.87%   92.81%   -0.07%     
==========================================
  Files          39       39              
  Lines        4616     4618       +2     
==========================================
- Hits         4287     4286       -1     
- Misses        239      241       +2     
- Partials       90       91       +1     
Impacted Files Coverage Δ
middleware/rate_limiter.go 96.90% <87.50%> (-3.10%) ⬇️
middleware/request_logger.go 97.56% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aldas
Copy link
Contributor Author

aldas commented Jul 11, 2023

note to self: "Run checks" fails because actions/setup-go has not been updated to know Go 1.20.6 existence

@aldas aldas merged commit 1ee8e22 into labstack:master Jul 11, 2023
11 of 13 checks passed
@aldas aldas deleted the refactor_timenows branch July 22, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data race in parallel test with RequestLogger middleware
1 participant