Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete unused context in body_limit.go #2483

Merged
merged 3 commits into from Jul 21, 2023
Merged

Conversation

mobinanoorii
Copy link
Contributor

according to this issue, I remove unused context in limitedReader struct

middleware/body_limit.go Show resolved Hide resolved
@aldas
Copy link
Contributor

aldas commented Jul 17, 2023

please run tests after changes and commit things that pass the tests. Currently this PR removes a field but one test still uses it.

if you are using Linux, probably MacOS also - you can just run make in CLI which will execute linter and tests for your.

@mobinanoorii
Copy link
Contributor Author

mobinanoorii commented Jul 18, 2023

should I update the test file too?
because of we don't need context anymore

@aldas
Copy link
Contributor

aldas commented Jul 18, 2023

yes, tests need to be fixed as they fail after that change. As this PR is deleting that field - parts that require that field need to be changed in tests.

@mobinanoorii
Copy link
Contributor Author

Ok I amend my latest commit and push again

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (a2e7085) 92.82% compared to head (adc9aee) 92.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2483      +/-   ##
==========================================
- Coverage   92.82%   92.81%   -0.01%     
==========================================
  Files          39       39              
  Lines        4624     4623       -1     
==========================================
- Hits         4292     4291       -1     
  Misses        241      241              
  Partials       91       91              
Impacted Files Coverage Δ
middleware/body_limit.go 95.91% <100.00%> (-0.09%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aldas aldas merged commit 3f8ae15 into labstack:master Jul 21, 2023
13 checks passed
@aldas aldas mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants