Release locks on error #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a lock is acquired using a `with` block, and an exception occurs within that block, it should still be released. This commit uses a `try:` `finally:` structure to do this.
StrictLock and CompositeLock can be used as context managers in 2 ways. They are context manager classes (__enter__ and __exit__ methods) but the __call__ method is a generator context manager too - allowing arguments. This code now tests both forms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a difference in behaviour between:
and
The code that implements the latter (to allow arguments) does not release the lock if an error occurs. This is now fixed, and a test is added to check both code paths.
Closes #274