Menus seem to be displayed on the same layer as the parent

[spl237]

A small glitch I noticed yesterday.

We use pcmanfm to draw the desktop background; if you right-click the desktop, you get a pop-up menu.
On labwc, this menu displays underneath any windows which happen to be open - on wayfire, it displays on top of any open windows.

I suspect the layer-shell layer for the menu is being set to the same layer as the parent window which opens it - as the pcman desktop window is shown on the background layer, the menu gets set to the same layer, rather than the overlay layer where it should be displayed. Would it be better to make sure all menus get assigned to the overlay layer irrespective of parent layer?

[Consolatis]

The menu doesn't use the layershell protocol but is rather a usual xdg popup.

We do move popups created by layershell clients to the top layer, however we apparently only do that when created by "bottom" layershell surfaces:

labwc/src/layers.c

Lines 365 to 368 in b34d074

	if (surface->layer_surface->current.layer
	== ZWLR_LAYER_SHELL_V1_LAYER_BOTTOM) {
	move_popup_to_top_layer(toplevel, popup);
	}

So it should be easy to fix, will do it later if you don't beat me to it (== -> <=).

[spl237]

I'll leave you to it - you'll know where to look! Many thanks!

[spl237]

Just checked on a quick hack here - just modifying that test to check for either LAYER_BOTTOM or LAYER_BACKGROUND does indeed fix the problem.

[Consolatis]

Should be fixed in latest master. Thanks for the report.

[spl237]

Yes, just tested here - fixed for me - many thanks!