Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlwaysOnTop windows don't appear in the OSD #856

Closed
ghost opened this issue Mar 29, 2023 · 3 comments
Closed

AlwaysOnTop windows don't appear in the OSD #856

ghost opened this issue Mar 29, 2023 · 3 comments
Labels
enhancement New feature or request later Not priority at the moment UX User Experience issues

Comments

@ghost
Copy link

ghost commented Mar 29, 2023

Easy to replicate, toggle any window AlwaysOnTop via the graphical client-menu and then Alt+Tab.
It happens with Wayland native programs and Xwayland as well. I only tested this on the lastest git master.
I believe this is a bug because the user cannot gain control back on the "OnTop" window.

@Consolatis Consolatis added enhancement New feature or request later Not priority at the moment UX User Experience issues labels Mar 30, 2023
@Consolatis
Copy link
Member

Consolatis commented Mar 30, 2023

Note about implementing a fix:
We might need to return to looping over server->views with a filter for node->parent being either the current workspace tree or the always-on-top tree. That should fix it.
It would also allow for a future rc.xml setting to show windows from all workspaces in A-Tab if set.

@Consolatis
Copy link
Member

Consolatis commented Apr 1, 2023

I actually intend to revert to using server->views + filter for current workspace (at least for A-Tab) because otherwise always-on-top views (and other non direct children of the workspace nodes) will not show up there (#856).

I had been thinking similar thoughts 😄
+possibly showing all workspaces in windowSwitcher? I know we said originally that we wouldn't but...
Preview would be hard I guess - but possibly not needed for other workspaces.

Originally posted by @johanmalm in #866 (comment)

Good point regarding preview. Guess there is still some stuff to work out if we ever decide to add that config option.

@johanmalm
Copy link
Collaborator

COMPLETE
c71fccb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request later Not priority at the moment UX User Experience issues
Projects
None yet
Development

No branches or pull requests

2 participants