Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD Improvements #2 #968

Open
10 of 17 tasks
johanmalm opened this issue Jun 29, 2023 · 9 comments
Open
10 of 17 tasks

OSD Improvements #2 #968

johanmalm opened this issue Jun 29, 2023 · 9 comments

Comments

@johanmalm
Copy link
Collaborator

johanmalm commented Jun 29, 2023

This relates to #879 #893 - but I'm just creating a new issue so that I can control the original post.

  • item height based on font height OSD improvements #893
  • window switcher width OSD improvements #893
  • item vertical padding OSD improvements #893
  • focused item border width theme: add option osd.window-switcher.padding #970
  • window-switcher padding theme: add option osd.window-switcher.padding #970
  • possible to hide each of 3 columns
  • size of the squares in desktop switcher (with osd.workspace-switcher.boxes.width/height)
  • osd.c: simplify the get_title() helper and associated is_title_different()
  • Show always on-top windows in window-switcher
  • Consider showing multiple work-spaces in window-switcher
  • focused item background and text color
  • position of desktop name (top/bottom)
  • different font size for desktop switcher and window switcher
  • Consider allowing window-switcher width to be specified as a percentage of output width
  • Cope with nr_items * item_height > output_height
  • Consider grouping by workspace in window-switcher
  • Consider showing window thumbnails
@Consolatis
Copy link
Member

focused item border width doesn't seem to be implemented?

@stefonarch
Copy link
Contributor

stefonarch commented Jun 30, 2023

I'll drop just my 2 cents here: I do not much like the square border of the selected item - why not use the same hover color as in window title menu's selected items? Or an option to disable for it?

@Consolatis
Copy link
Member

Consolatis commented Jun 30, 2023

We can allow for that when the three new theme vars are implemented:

  • focused.border.width: 0 (or focused.thickness or whatever naming we come up with)
  • focused.bg.color: #whatever
  • focused.text.color: #whatever

@droc12345
Copy link
Contributor

Consider showing multiple work-spaces in window-switcher

should be checked?

@Consolatis
Copy link
Member

Consolatis commented Mar 23, 2024

Consider showing multiple work-spaces in window-switcher

should be checked?

Thanks, checked and added a new Consider grouping by workspace in window-switcher.
(Also reordered the list so the checked items are on top to easier see what is still open.)

@droc12345
Copy link
Contributor

Consolatis, did you want me to fix the rest of the custom config for window switcher?
I think basically it needs doc (which I don't have a problem doing) and removing a few things from
your patch that have already been applied to labwc, ie repackage what you have in the patch.
I know you pointed to a few possible enhancements/fixes, but those could be done after merge
as fine tuning the code.

I've been using it as my daily way to use window switcher, been working well.
Putting it in would allow others to start testing it also.

@Consolatis
Copy link
Member

Consolatis, did you want me to fix the rest of the custom config for window switcher? I think basically it needs doc (which I don't have a problem doing) and removing a few things from your patch that have already been applied to labwc, ie repackage what you have in the patch.

If you have the time and motivation to do so, feel free :)
Got side tracked, too many things to work on simultaneously.

@droc12345
Copy link
Contributor

I knew you were busy, thus the offer

#1654

@Vladimir-csp
Copy link

Please also consider adding ability to theme window focus highlight frame, potentially into something other than 3-pixel 2-color frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants