-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSD customizations #879
Comments
Same here, I recently tried a large font size but the line height does not scale, so the displayed lines start to overlap. |
Hm.. right. Although we actually calculate the line height of the configured font, we only subtract it from a hardcoded item height (20px) to center the line. So if the line height based on the font config is > 20px, stuff starts to get wrong. We should likely replace that logic with some theme setting like In the meantime, if you feel like modifying the code itself to make your local copy work for bigger font sizes, |
Thanks for sharing the insights. So, I believe, this whole thing is actually 2 things:
|
Add theme options - osd.window-switcher.item.width - osd.window-switcher.item.padding.x - osd.window-switcher.item.padding.y Calculate window switcher item-height using font-height() + 2 * padding.y Issue labwc#879
Add theme options - osd.window-switcher.item.width - osd.window-switcher.item.padding.x - osd.window-switcher.item.padding.y Calculate window switcher item-height using font-height() + 2 * padding.y Issue labwc#879
...and calculate item-height based on font-height Add theme options - osd.window-switcher.width - osd.window-switcher.item.padding.x - osd.window-switcher.item.padding.y Issue labwc#879
...and calculate item-height based on font-height Add theme options - osd.window-switcher.width - osd.window-switcher.item.padding.x - osd.window-switcher.item.padding.y Issue labwc#879
...and calculate item-height based on font-height Add theme options - osd.window-switcher.width - osd.window-switcher.item.padding.x - osd.window-switcher.item.padding.y Issue #879
Will track this in #968 |
It would be awesome if we can have following configurations for the OSD:
Thanks a lot. Looking forward for you to add these features.
The text was updated successfully, but these errors were encountered: