Implement key binds to control virtual outputs #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now possible to use keybinds to add and remove virtual outputs (also called headless backend in wlroots terminology).
Consolatis
reviewed
Dec 6, 2023
Consolatis
reviewed
Dec 6, 2023
Consolatis
reviewed
Dec 6, 2023
Consolatis
reviewed
Dec 6, 2023
|
@Consolatis thanks for your review. I've addressed your comments. Do I need to squash everything into a single commit? |
@kyak up to you. In general yes but we can also do that when merging. As this is a feature that I helped to design and we usually don't self-merge I'd prefer if @johanmalm could have a final look over this PR. From my POV this is ready to go after squashing. |
johanmalm
reviewed
Dec 8, 2023
|
Happy in principle. Just a bunch of fairly trivial comments. |
|
@johanmalm thanks! I've addressed most of your comments. Kept it in separate to-be-squashed commits for better traceability. |
johanmalm
reviewed
Dec 9, 2023
|
Great effort. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to use keybinds to add and remove virtual outputs (also called headless backend in wlroots terminology).
Closes #1279
Thanks to @Consolatis for original PoC patch and guidance!