Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SetDecorations action #1733

Merged
merged 3 commits into from
May 19, 2024
Merged

add SetDecorations action #1733

merged 3 commits into from
May 19, 2024

Conversation

xi
Copy link
Contributor

@xi xi commented Apr 20, 2024

as discussed in IRC. resolves #1728

We also discussed adding a "decorations" query for the if-action. I will work on that separately, but this already lays some ground work (e.g. view_get_ssd_mode).

@johanmalm
Copy link
Collaborator

I appreciate the work on this and noted the lengthy analysis. I haven’t been able to keep up with the story/thinking so if you want me to review anything, please could you point me to it.

If @ahesford or @Consolatis are already on the case I’m happy not to duplicate effort, but as I said if independent view is required (by me) please make it clear.

include/view.h Outdated Show resolved Hide resolved
include/ssd.h Outdated Show resolved Hide resolved
@johanmalm
Copy link
Collaborator

Thanks for working on this. Sorry it took a while to get into the merge window.

@johanmalm johanmalm merged commit 41a3b68 into labwc:master May 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleaner approach to decorations
4 participants