further changes for stall count

lacava · Jun 17, 2017 · 05ef0c4 · 05ef0c4
1 parent 65ff473
commit 05ef0c4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/few/tests/test_few.py b/few/tests/test_few.py
@@ -67,15 +67,6 @@ def test_few_with_parents_weight():
     few_score = learner.score(features[:300], target[:300])
     test_score = learner.score(features[300:],target[300:])
 
-    lasso = LassoLarsCV()
-    lasso.fit(learner._training_features,learner._training_labels)
-    lasso_score = lasso.score(features[:300], target[:300])
-    print("few score:",few_score,"lasso score:",lasso_score)
-    print("few test score:",test_score,"lasso test score:",lasso.score(features[300:],target[300:]))
-    assert few_score >= lasso_score
-
-    print("lasso coefficients:",lasso.coef_)
-
 
 def test_few_at_least_as_good_as_default():
     """test_few.py: few performs at least as well as the default ML """

diff --git a/few/variation.py b/few/variation.py
@@ -31,7 +31,7 @@ def variation(self,parents):
             elif hasattr(self.ml,'feature_importances_'):
                 # for tree methods, filter our individuals with 0 feature importance
                 if self.weight_parents:
-                    weights = abs(self.ml.feature_importances_)
+                    weights = self.ml.feature_importances_
                     weights = weights/sum(weights)
                     offspring = copy.deepcopy(list(np.random.choice(self.valid(parents), self.population_size, p=weights)))
                 else: