Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard scaler pipeline #26

Merged
merged 2 commits into from
Jul 5, 2017
Merged

standard scaler pipeline #26

merged 2 commits into from
Jul 5, 2017

Conversation

rgupta90
Copy link
Collaborator

@rgupta90 rgupta90 commented Jul 5, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 73.101% when pulling 9124540 on standard_scaler into 59f339e on master.

Copy link
Owner

@lacava lacava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some small changes to clean up the syntax

few/few.py Outdated
self.ml = ml
self.ml_type = type(self.ml).__name__
self.ml = Pipeline([('standardScaler',StandardScaler()), ('ml', ml)])
self.ml_type = type(self.ml.steps[1][1]).__name__
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ml.named_steps['ml']

few/few.py Outdated
@@ -116,11 +117,13 @@ def __init__(self, population_size=50, generations=100,
self.boolean = True

# instantiate sklearn estimator according to specified machine learner
if self.ml is None:
if self.ml.steps[1][1] is None:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comment

few/few.py Outdated
@@ -146,7 +149,7 @@ def __init__(self, population_size=50, generations=100,
type(DecisionTreeClassifier()): 'r2',
type(DistanceClassifier()): 'silhouette',
type(KNeighborsClassifier()): 'r2',
}[type(self.ml)]
}[type(self.ml.steps[1][1])]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comment

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 73.101% when pulling fe6043f on standard_scaler into 59f339e on master.

@lacava lacava merged commit aa214bb into master Jul 5, 2017
@lacava lacava deleted the standard_scaler branch July 5, 2017 21:40
@lacava lacava restored the standard_scaler branch July 5, 2017 21:52
@lacava lacava deleted the standard_scaler branch October 6, 2017 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants