The block variable was keeping too much memory while waiting for futu…

…re to finish (hyperledger#4489) Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
lacchain · Nov 3, 2023 · 5d849b9 · 5d849b9
1 parent cf8004d
commit 5d849b9
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...a/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/EngineNewPayload.java b/...a/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/EngineNewPayload.java
@@ -176,6 +176,7 @@ public JsonRpcResponse syncResponse(final JsonRpcRequestContext requestContext)
 
     final var block =
         new Block(newBlockHeader, new BlockBody(transactions, Collections.emptyList()));
+    final String warningMessage = "Sync to block " + block.toLogString() + " failed";
 
     if (mergeContext.get().isSyncing() || parentHeader.isEmpty()) {
       LOG.debug(
@@ -187,8 +188,7 @@ public JsonRpcResponse syncResponse(final JsonRpcRequestContext requestContext)
           .appendNewPayloadToSync(block)
           .exceptionally(
               exception -> {
-                LOG.warn(
-                    "Sync to block " + block.toLogString() + " failed", exception.getMessage());
+                LOG.warn(warningMessage, exception.getMessage());
                 return null;
               });
       return respondWith(reqId, blockParam, null, SYNCING);