Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Team and Owner to MachineTags #1615

Closed
vallieres opened this issue Apr 22, 2024 · 2 comments · Fixed by #1618
Closed

feat: Add Team and Owner to MachineTags #1615

vallieres opened this issue Apr 22, 2024 · 2 comments · Fixed by #1618
Labels
feat New feature or request

Comments

@vallieres
Copy link

Feature Request

Describe the Feature Request
We are using the information from those field in our internal tooling, however, these two fields are present in API response, but not in the Go struct that used to unmarshal the response.

Is your feature request related to a problem? Please describe
A problem for us since we need it, but it's not a bug or error.

Describe Preferred Solution
Adding the two fields would be sufficient.

Additional Context
List any other information that is relevant to your issue. Stack traces, related issues, suggestions on how to add, use case, Stack Overflow links, forum links, screenshots, OS if applicable, etc.

@vallieres vallieres added the feat New feature or request label Apr 22, 2024
@ipcrm
Copy link
Collaborator

ipcrm commented Apr 25, 2024

Some discussion here on this in #1616, see (#1616 (comment)). Will raise another PR to add a method that returns all the tags in a map[string]interface{}.

ipcrm added a commit that referenced this issue Apr 25, 2024
Fixes #1615

Enable accessing the raw machine tags for external automation
@ipcrm
Copy link
Collaborator

ipcrm commented Apr 25, 2024

@vallieres please take a look at #1618 and confirm that'll get what you need, thx!

ipcrm added a commit that referenced this issue Apr 29, 2024
Fixes #1615

Enable accessing the raw machine tags for external automation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants