Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure account should validate customer does not include lacework.net #86

Closed
scottford-lw opened this issue Apr 29, 2020 · 0 comments · Fixed by #187
Closed

Configure account should validate customer does not include lacework.net #86

scottford-lw opened this issue Apr 29, 2020 · 0 comments · Fixed by #187
Labels
cli Something related to the Lacework CLI feat New feature or request

Comments

@scottford-lw
Copy link
Contributor

scottford-lw commented Apr 29, 2020 •
edited by ghost
Loading

We should ensure that the lacework configure subcommand validates the account does not include .lacework.net or handles it correctly if that is passed.
@ghost ghost changed the title [cli] Configure account should validate customer does not include lacework.com [cli] Configure account should validate customer does not include lacework.net May 3, 2020
@afiune afiune added cli Something related to the Lacework CLI feat New feature or request labels Jun 4, 2020
@afiune afiune changed the title [cli] Configure account should validate customer does not include lacework.net Configure account should validate customer does not include lacework.net Jun 4, 2020
afiune added a commit that referenced this issue Aug 6, 2020
@afiune
feat(cli): better account validation
5a8a7f6 
This change will add a better validation so that if the user provides
the complete URL as the account name while running the
`lacework configure` command the following error message will be
prompted:

```
$ lacework configure
X Sorry, your reply was invalid: The account should only be the subdomain of URL (i.e. <ACCOUNT>.lacework.net)
▸ Account: tech-ally.lacework.net
```

Closes #86

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
@afiune afiune mentioned this issue Aug 6, 2020
Merged
afiune added a commit that referenced this issue Aug 6, 2020
@afiune
feat(cli): better account validation
57b8acd 
This change will add a better validation so that if the user provides
the complete URL as the account name while running the
`lacework configure` command the following error message will be
prompted:

```
$ lacework configure
X Sorry, your reply was invalid: The account should only be the subdomain of URL (i.e. <ACCOUNT>.lacework.net)
▸ Account: tech-ally.lacework.net
```

Closes #86

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune added a commit that referenced this issue Aug 10, 2020
@afiune
feat(cli): better ux in account validation
396c152 
This change will add a better user-experience to the lacework configure
command so that if the user provides the complete URL as the account
name we will subtract the account and notify the end-user:

```
$ lacework configure
Account subtracted from URL 'tech-ally.lacework.net' (should only be the subdomain of URL)
▸ Account: tech-ally
▸ Access Key ID: TECHALLY_1234567890
▸ Secret Access Key: (*****************************91f3)

You are all set!
```

Closes #86

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune added a commit that referenced this issue Aug 11, 2020
@afiune
feat(cli): better ux in account validation
b4a502d 
This change will add a better user-experience to the lacework configure
command so that if the user provides the complete URL as the account
name we will subtract the account and notify the end-user:

```
$ lacework configure
Passing '.lacework.net' domain not required. Using 'tech-ally'
▸ Account: tech-ally
▸ Access Key ID: TECHALLY_1234567890
▸ Secret Access Key: (*****************************91f3)

You are all set!
```

Closes #86

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune added a commit that referenced this issue Aug 11, 2020
@afiune
feat(cli): better ux in account validation (#187)
cdd045a 
This change will add a better user-experience to the lacework configure
command so that if the user provides the complete URL as the account
name we will subtract the account and notify the end-user:

```
$ lacework configure
Passing '.lacework.net' domain not required. Using 'tech-ally'
▸ Account: tech-ally
▸ Access Key ID: TECHALLY_1234567890
▸ Secret Access Key: (*****************************91f3)

You are all set!
```

Closes #86

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Something related to the Lacework CLI feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): better ux in account validation lacework/go-sdk
2 participants
@afiune @scottford-lw