Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ease the run of manual acceptance tests #389

Closed
ceilfors opened this issue Nov 12, 2019 · 4 comments

Comments

@ceilfors
Copy link
Member

@ceilfors ceilfors commented Nov 12, 2019

Is your feature request related to a problem? Please describe.
There are a couple of issues when contributors are trying to run an acceptance test by themselves:

  1. SSM secret is not created automatically. The following error will occur:
{
"errorMessage": "Invalid parameters: /laconia-acceptrance-node8/apikey",
"errorType": "Error",
"stackTrace": [
"validateSsmData (/var/task/node_modules/@laconia/config/src/SsmConfigConverter.js:3:11)",
"SsmConfigConverter._getParameterMap (/var/task/node_modules/@laconia/config/src/SsmConfigConverter.js:19:5)",
"<anonymous>",
"process._tickDomainCallback [as _tickCallback] (internal/process/next_tick.js:228:7)"
]
}
  1. S3 buckets has a name conflict. The following error will occur:
An error occurred: S3Tracker - laconia-acceptance-node8-tracker already exists.

Describe the solution you'd like

  • Contributors should be able to run acceptance test to their own AWS account with one command
  • And/or, the steps to run the acceptance test must be documented well

Additional context

@ceilfors

This comment has been minimized.

Copy link
Member Author

@ceilfors ceilfors commented Nov 12, 2019

SecureString is not something that we can create automatically via CloudFormation. But someone in StackOverflow suggested that we can use Custom Resource

@hugosenari

This comment has been minimized.

Copy link
Contributor

@hugosenari hugosenari commented Dec 4, 2019

https://docs.aws.amazon.com/AmazonS3/latest/dev/BucketRestrictions.html#bucketnamingrules

Bucket names must be unique across all existing bucket names in Amazon S3.

This mean that S3 bucket name must contain accountId.

hugosenari pushed a commit to hugosenari/laconia that referenced this issue Dec 4, 2019
hugosenari pushed a commit to hugosenari/laconia that referenced this issue Dec 4, 2019
ceilfors added a commit that referenced this issue Dec 6, 2019
Add accountId to buckets name
@hugosenari

This comment has been minimized.

Copy link
Contributor

@hugosenari hugosenari commented Dec 6, 2019

#432 and #435 fix this issue

@hugosenari hugosenari closed this Dec 6, 2019
@ceilfors

This comment has been minimized.

Copy link
Member Author

@ceilfors ceilfors commented Dec 6, 2019

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.