Update acceptance test runtime from node8 to node10 #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter is being created in acceptance.spec.js because CloudFormation does not support SecretString creation, obviously due to security reason. In our case, as this is not really a secret, it is safe for us to have the plain text secret in our test. This closes #418
hugosenari
reviewed
Dec 4, 2019
hugosenari
reviewed
Dec 4, 2019
| "deploy:8": "AWS_REGION=eu-west-1 NODE_RUNTIME=nodejs8.10 NODE_VERSION=node8 sls deploy", | ||
| "remove": "npm run remove:8", | ||
| "remove:8": "AWS_REGION=eu-west-1 NODE_RUNTIME=nodejs8.10 NODE_VERSION=node8 sls remove" | ||
| "test": "npm run test:10", |
There was a problem hiding this comment.
Maybe, now we could use version as number (ie: 10) NODE_MAJOR=10
runtime: nodejs${env:NODE_MAJOR, '10' }.x
stage: node${env:NODE_MAJOR, '10' }{
"test": "jest /acceptance-test",
"test:10": "NODE_MAJOR=10 npm test",
"deploy": "sls deploy",
"deploy:10": "NODE_MAJOR=10 npm run deploy",
"remove": "sls remove",
"remove:10": "NODE_MAJOR=10 npm run remove"
}We need set default value to SERVERLESS_STAGE.
|
Add some discussion, maybe for other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also create the required apikey parameter automatically
The parameter is being created in acceptance.spec.js because CloudFormation does not support SecretString creation, obviously due to security reason.
In our case, as this is not really a secret, it is safe for us to have the plain text secret in our test.
This closes #418