Skip to content
This repository has been archived by the owner on Mar 18, 2022. It is now read-only.

No cache busting in CSS scraper? #20

Closed
grydstedt opened this issue Sep 27, 2012 · 9 comments
Closed

No cache busting in CSS scraper? #20

grydstedt opened this issue Sep 27, 2012 · 9 comments

Comments

@grydstedt
Copy link

Might have misunderstood this, but shouldn't the CSS image scraper replace the resource with the cache busted image?

return attribute+':url('+url+')';

@niftylettuce
Copy link
Collaborator

yeah it should, though that was not integrated when he sent over the pull request -- do you mind adding it?

@grydstedt
Copy link
Author

Sure, will do.

We should consider adding font assets as well.

@niftylettuce
Copy link
Collaborator

yeah definitely, i had the pain of manually setting meta attr's for my webfonts in the bucket, ugh!

@niftylettuce
Copy link
Collaborator

@grydstedt can you send over a pull request with this feature integrated? could use all the help! thx :)

@niftylettuce
Copy link
Collaborator

@grydstedt have any luck? let me know!

@niftylettuce
Copy link
Collaborator

@grydstedt how goes it?

@grydstedt
Copy link
Author

Hey, sorry. To busy on personal projects to be able to contribute unfortunately. Would love to though.

@niftylettuce
Copy link
Collaborator

@grydstedt have you found time to contribute? would love to have your support with express-cdn -- we just released v0.1.0 with several fixes and now using jpegtran and optipng bins via npm!

@niftylettuce
Copy link
Collaborator

Adding this to Lazyweb requests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants