Housekeeping - get build/tests running #78
Conversation
Error from babel: The 'polyfill' option has been removed. The @babel/runtime module now skips polyfilling by default.
it appears that @babel/preset-env ignores .browserslistrc when `targets` are provided (node 6.4.0 in this case)
Regex used: (t)hrows\(([^(].*)\); $1hrows(() => $2);
error from ava: Function returned a promise. Use `t.throwsAsync()` instead:
Since xo version is locked down, the ava rules are out-of-date. This was the least-changes way to get build working.
|
Hmm, looks like the node v6 & v9 tests are running into For node 6, eslint-plugin-compat causes an error: For node 9, ava causes an error: |
|
We can drop support for Node version 6.x and only support LTS versions v8.x and v10.x End of life for v6.x is April 2019, which is only 2 months away. https://github.com/nodejs/Release#release-schedule |
|
That sounds good. Having |
|
@davidgovea I believe https://github.com/niftylettuce/frisbee/blob/master/.babelrc#L5 needs updated to target 8.x |
|
@davidgovea also see 52310f9 |
|
@davidgovea what is your PayPal? I owe you some bounties. Feel free to email it to niftylettuce@gmail.com if you wish to keep private. |
|
Also could you tackle https://github.com/niftylettuce/bug-bounties/issues/5 too? 💯 I would prob double bounty if you did. |
|
@niftylettuce awesome! Just added another PR for the bump And yep, was already starting some research on niftylettuce/bug-bounties#5 :) Going to take deeper dive comparing the libraries you listed, as well as other retry-scheduling utilities. |
|
@davidgovea thanks! version 2.0.6 of frisbee has been released, see https://github.com/niftylettuce/frisbee/releases/tag/v2.0.6 for release notes. I've also updated the README at https://github.com/niftylettuce/frisbee and provided clearer examples and usage. |
|
@davidgovea just let me know what your PayPal is - I also make you a collaborator on this repo |
Been using frisbee for about a year now, and came across the bug-bounty repo today. Was getting started on the cross-fetch task, but ran into some deprecations/build issues.
There were a handful of separate issues, but for this PR I took the approach of minimum change.
.babelrc..browserlistrcwas being ignored due to thetargetsconfig of@babel/envin the .babelrc file. The build containedclass,constetc, while current release version of frisbee has only es5-level code. Tests were refusing to run.throwsassertions have changed since 1.0-beta versions of ava.1.0.0-beta.4, but the yarn.lock already had a more recent version, so I figured a light test refactor was appropriateGoing to start the cross-fetch task from here, but would be happy to explore different approaches to anything.