Document that 3xx status codes are errors #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is not quite accurate. 3xx by default are considered redirects and don't cause errors. They become errors only in non-default case where you disable/limit number of redirects. |
|
Ah. In that case, what would be a good way to document the behavior for |
|
Oh, I've forgotten about that one. Yes, it is an error indeed (we're unable to get its body). Perhaps clarify with "non-redirecting 3xx" |
|
I pushed another version of the copy. Please take a look. ✍️ 👀 |
|
That's good. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the discussion in #283 as well as the code in the latest release, 3xx responses are considered errors by default.
This PR increases clarity about this point in the docs.