Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix part content-disposition #310

Merged
merged 1 commit into from Jan 12, 2014
Merged

fix part content-disposition #310

merged 1 commit into from Jan 12, 2014

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Jan 11, 2014

For a content-type of 'multipart/form-data', the content-disposition of each child part must be 'form-data' (and not 'attachment' for files).

For a content-type of 'multipart/form-data', the content-disposition of each child part must be 'form-data' (and not 'attachment' for files).
tj added a commit that referenced this pull request Jan 12, 2014
fix part content-disposition
@tj tj merged commit 9742f24 into ladjs:master Jan 12, 2014
@cheddar cheddar mentioned this pull request Jan 22, 2014
@jessefulton
Copy link

+1 would love to see this get into supertest. Any suggestions on a temporary workaround? (I tried forking supertest to use the latest master of superagent, but it doesn't seem to be firing the Busboy events in my API routes...)

Edit: I had another issue in my route... looks like my fork is working fine. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants