Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest superagent which has a fixed cookiejar. #302

Merged
merged 2 commits into from
Feb 11, 2016

Conversation

andyburke
Copy link
Contributor

This updates to the latest superagent, which includes a cookiejar that addresses some bugs.

@awochna
Copy link

awochna commented Dec 17, 2015

I also have encountered bugs in the current version of supertest that really come from the older version of superagent it's using.

+1 for merger!

@andrenarchy
Copy link

+1 for updating the superagent dependency. Actually, why does supertest use ~ dependencies? We wouldn't need this kind of PR with ^ dependencies (which means: use latest version with matching major version number – which should guarantee compatibility).

@nschloe
Copy link

nschloe commented Jan 16, 2016

+1 For ^1.0.0.

@andrenarchy
Copy link

Any updates?

@zensh
Copy link

zensh commented Feb 1, 2016

+1 for superagent v1.7.2

@andrenarchy
Copy link

Since this repo seems to be abandoned, we can use one of the forks with updated dependencies, see here and here.

@mikelax
Copy link
Contributor

mikelax commented Feb 10, 2016

Sorry I have been absent for a while, I'm back and can get this merged in.
Can you also up the version ^1.7.2 for me being pedantic?

@mikelax mikelax added this to the 1.2.0 milestone Feb 10, 2016
@andyburke
Copy link
Contributor Author

Done.

@andyburke
Copy link
Contributor Author

I am excited to back out my horrible postinstall hax. 🎉

mikelax added a commit that referenced this pull request Feb 11, 2016
Update to latest superagent which has a fixed cookiejar.
@mikelax mikelax merged commit 0583e3b into ladjs:master Feb 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants