Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved robustness of Array type check by using
isArray
instead of instanceof.I have a project with supertest (^3.1.0) and Jest (^23.0.0) as test runner. For some reason, that I haven't yet been able to pinpoint, the array instance check fails for me.
Vars in scope:
when I evaluate the following expressions I get:
changing the check to use
isArray
makes it work for me.I suspect I'm running into some of the issues described over here: http://perfectionkills.com/instanceof-considered-harmful-or-how-to-write-a-robust-isarray/