Updated tests to use trustLocalhost() for bypassing broken HTTPS #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
|
@rimiti I can't cause any regressions with existing or new tests. I'm slightly confused what #534 actually addressed. Also, historically we would keep superagent and supertest versioned similarly since any breaking superagent changes will generally affect supertest as well -- How about we just call this v4.0.0, whether you can find regressions or not. Thoughts? |
|
@gjohnson Yes, the superagent update can cause regressions (a breaking change), I'm totally agree to tagging it v4.0.0. I'm working on it (use-trust-localhost branch). I'll release today. 🚀 Thanks @gjohnson and @tejashah88 for your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues #396, #146 and #549.