feat(hvac): Refactor HVAC to be extensible for future systems #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswmackey
added
documentation
chriswmackey
added a commit
to chriswmackey/honeybee-openstudio-gem
that referenced
this pull request
Jan 14, 2020
This commit overhauls how HVAC systems are represented in the schema. Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model schema in order to support this. This commit is coordinated with [this PR over on honeybee_energy](ladybug-tools/honeybee-energy#69) and [this PR in honeybee_shcema](ladybug-tools/honeybee-schema#12)
chriswmackey
added a commit
to chriswmackey/honeybee-openstudio-gem
that referenced
this pull request
Jan 14, 2020
This commit overhauls how HVAC systems are represented in the schema. Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model schema in order to support this. This commit is coordinated with [this PR over on honeybee_energy](ladybug-tools/honeybee-energy#69) and [this PR in honeybee_shcema](ladybug-tools/honeybee-schema#12)
chriswmackey
added a commit
to chriswmackey/honeybee-openstudio-gem
that referenced
this pull request
Jan 14, 2020
This commit overhauls how HVAC systems are represented in the schema. Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model schema in order to support this. This commit is coordinated with [this PR over on honeybee_energy](ladybug-tools/honeybee-energy#69) and [this PR in honeybee_shcema](ladybug-tools/honeybee-schema#12)
This commit overhauls how HVAC systems are represented in the schema. Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model schema in order to support this. This commit is coordinated with [this PR over on honeybee_energy](ladybug-tools/honeybee-energy#69)
chriswmackey
added a commit
to chriswmackey/honeybee-openstudio-gem
that referenced
this pull request
Jan 14, 2020
This commit overhauls how HVAC systems are represented in the schema. Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model schema in order to support this. This commit is coordinated with [this PR over on honeybee_energy](ladybug-tools/honeybee-energy#69) and [this PR in honeybee_shcema](ladybug-tools/honeybee-schema#12)
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
chriswmackey
added a commit
to ladybug-tools/honeybee-openstudio-gem
that referenced
this pull request
Jan 14, 2020
This commit overhauls how HVAC systems are represented in the schema. Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model schema in order to support this. This commit is coordinated with [this PR over on honeybee_energy](ladybug-tools/honeybee-energy#69) and [this PR in honeybee_shcema](ladybug-tools/honeybee-schema#12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit overhauls how HVAC systems are represented in the schema.
Specifically, it makes it possible in the future to support HVAC systems that are assigned to multiple Rooms (like most of the HVAC system templates in honeybee_legacy). It also restructures the representation of HVAC within the Model schema in order to support this.
This commit is coordinated with this PR over on honeybee_energy