Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in definition of mixfunc #217

Closed
sariths opened this issue Apr 30, 2018 · 2 comments
Closed

Typo in definition of mixfunc #217

sariths opened this issue Apr 30, 2018 · 2 comments
Assignees
@mostaphaRoudsari
Labels
bug radiance

Comments

@sariths
Copy link
Contributor

sariths commented Apr 30, 2018 •
edited

There is a typo for mixfunc. It has been defined as mixedfunc. This will likely throw an exception at the time of type checking.

honeybee/honeybee/radiance/material/_materialbase.py

Lines 18 to 19 in 4226a25

TYPES = set(("plastic", "glass", "trans", "metal", "mirror", "texfunc", "illum",
"mixedfunc", "dielectric", "transdata", "light", "glow", "BSDF"))

Reported on the forum by Tobias Skov: http://discourse.ladybug.tools/t/honeybee-custom-materials/2863/4

(PS: I would have done this myself, but I am still pretty rusty as I haven't played around with the core library in a while)
@mostaphaRoudsari
Copy link
Member

@sariths thank you for this! This is a bug and as I replied on discourse it will be fixed once I push the new changes to GitHub!

@mostaphaRoudsari
Copy link
Member

This is fixed via fca77a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mostaphaRoudsari mostaphaRoudsari

Labels
bug radiance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mostaphaRoudsari @sariths