Refine Sunpath code

[mostaphaRoudsari]

Ladybug legacy Sunpath gives slightly different results than NOAA solar calculator.

I made a number of adjustments in order to fix the difference in Ladybug[+] but I ended up making it worse. The source code is available here

We need to check this once and forever and write a number of test to make sure no upcoming change will affect the accuracy of the code.

@devngc will be in charge.

PS: This is one of the first classes that I wrote for Ladybug[+] and should have a lot of room for improvements.

[ParametricMonkey]

@mostaphaRoudsari @devngc any luck with this?

[devang-chauhan]

@ParametricMonkey ,
Apologies for the delay. I just saw your post. I will update here as soon as I fix this.

[ParametricMonkey]

@mostaphaRoudsari This issue has been closed but has it been implemented into Dynamo yet? I'm on the latest version 0.1.9.

[mostaphaRoudsari]

@ParametricMonkey, No. I haven't updated the plugins yet for compatibility issues with honeybee. I'm working on them right now and have an internal deadline for end of this week.

[ParametricMonkey]

@mostaphaRoudsari how did you go with the internal deadline?

[mostaphaRoudsari]

@ParametricMonkey! Sorry for the delay. I'm writing the release notes right now! Expect it out in a day or two.

[ParametricMonkey]

@mostaphaRoudsari @devngc
I've been revisiting this and there still seems to be a discrepancy. Using Ladybug 0.2.1 in Dynamo with Revit 2018, I'v created views from the sun and then turned on shadows. There should be no shadows visible but it is slightly out. Does this mean that Revit doesn't use NOAA or is there a bug in Ladybug?

[mostaphaRoudsari]

@ParametricMonkey does the location exactly match? Can you get the sun vectors from Revit? That is the only way to do a legit comparison between the two and NOAA algorithm. Also this might deserve a new issue or a question on the forum.

[ParametricMonkey]

@mostaphaRoudsari

posted here: https://discourse.ladybug.tools/t/solar-vector-discrepancy/7220