-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add task for creating an API token for the superuser #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good style overall. Some additional things apart from the review comments:
- Please add documentation to the
README.adoc
for the new role variable explaining what it does. create_token
might be a more appropriate name than 'token_enabled', since that's what's happening here.- Preferably, the role variable should also be configured in
tests/group_vars
as well so that CI will test it.
in our Environment we deploy the netbox with your role and after it we discover all of our infrastructure (that´s the reason for the token). We already use LDAP too. I changed it to an bool trigger and an or condition. I hope that's also fine for you. |
This'd be a great addition! Could we get a new review @lae ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, missed the followup comment. New review with a question.
readme and testing group_vars
Changes merged, but squashed into one commit due to the noisy commit history. This may pose an issue when trying to pull changes to your fork as you were working directly on your main branch (master) because the histories are different. There are various ways of dealing with this, but the easiest might just be deleting your fork and making a new fork. To avoid this in the future, consider creating a new temporary branch (we tend to call them "feature branches" or something similar, but they're technically all the same), making changes to that branch and then creating a PR off of that branch. |
HI, Thanks for the Information. I will do it like this in the future. |
hey,
i create a new default for deploy a api token for the superuser. we needed this for our project and let you know about this :)
thanks!