Installation error

[youth123]

Describe the bug
Failed to build fastmoe in the docker images that megatron provides.
https://ngc.nvidia.com/catalog/containers/nvidia:pytorch

To Reproduce
Steps to reproduce the behavior:
USE_NCCL=1 python setup.py install
Expected behavior
Installed successfully.
Logs
FAILED: /root/paddlejob/toyer_switch/fastmoe/build/temp.linux-x86_64-3.8/cuda/global_exchange.o
error: no matching function for call to ‘HackNCCLGroup::broadcastUniqueNCCLID(ncclUniqueId*)’
91 | broadcastUniqueNCCLID(&ncclID);
Platform

• Device: NVIDIA V100
• OS:Ubuntu
• CUDA version: 11.1
• NCCL version: 2.8.3

[youth123]

when I git reset --hard b861e92, it can be installed successfully.
But it failed in 9170835, maybe some commit between these commit ids caused.

[laekov]

I will look into this next week.

[laekov]

What is your PyTorch version? @youth123

[youth123]

What is your PyTorch version? @youth123

1.8.0

[laekov]

So, the difference is that we check pytorch's version using its macros here in order to be compatible to older PyTorch versions.
Can you check if your pytorch header files correctly define these macros?

[youth123]

Sorry to reply so late. My pytorch header files don't have TORCH_VERSION_MAJOR.

[laekov]

The macro is defined here in PyTorch 1.8.0. Its absense indicates that your PyTorch may be incorrectly installed.