New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Fonts QA report #11
Comments
Okay, great, thank you. So looking at these issues one-by-one:
|
Okay, fixed 2 and 6, new issue with names:
|
Ignore
Fix. Probably linked to the ExtraLight being 250
Ignore. This is an issue with FB.
Why not run grep on the dir with the values FB is finding? this should tell you which files you need to modify.
Use
That glyph is in the font, it is the commercialMinusSign. Remember we're checking binaries so the glyph names may have been converted from human readable names to uni names. Interestingly the glyph has been marked as non-exportable. I guess fontmake ignores this. If you don't need this glyph, you may as well delete it. |
Hey, great idea. 🎉 I'll delete the Thanks Marc. |
Remember these checks are broken for multi axes vfs so I'm rewriting them. As long as the instances comply to https://gist.github.com/m4rc1e/8f4c4498519e8a36cd54e16a004275cb#instance-names I'm happy. |
Excellent. Thanks again. |
Hey @m4rc1e, I now have a clean build except for fontbakery disliking 200 as a weight and the lack of a statics directory. |
Thanks! |
Fontbakery report
Fontbakery version: 0.7.18
[1] Family checks
⚠ WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?
[10] Russolo[opsz,wght].ttf
🔥 FAIL: DESCRIPTION.en_us.html must have less than 1000 bytes.
com.google.fonts/check/description/max_length
🔥 FAIL DESCRIPTION.en_us.html must have size smaller than 1000 bytes. [code: too-long]
🔥 FAIL: Variable font weight coordinates must be multiples of 100.
🔥 FAIL: A static fonts directory with at least two fonts must accompany variable fonts
🔥 FAIL: Check variable font instances have correct coordinate values
com.google.fonts/check/varfont_instance_coordinates
🔥 FAIL Instance "10pt ExtraLight" wght value is "275.0". It should be "200.0" [code: bad-coordinate]
🔥 FAIL Instance "24pt ExtraLight" wght value is "275.0". It should be "200.0" [code: bad-coordinate]
🔥 FAIL Instance "72pt ExtraLight" wght value is "275.0". It should be "200.0" [code: bad-coordinate]
🔥 FAIL: Checking OS/2 Metrics match hhea Metrics.
🔥 FAIL: Are there unwanted tables?
Table: MVAR
Reason: Produces a bug in DirectWrite which causes https://bugzilla.mozilla.org/show_bug.cgi?id=1492477, Quicksand font: letters cropped in <select> google/fonts#2085
They can be removed with the gftools fix-unwanted-tables script.
🔥 FAIL: Check glyphs do not have duplicate components which have the same x,y coordinates.
⚠ WARN: Is there kerning info for non-ligated sequences?
⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:
[code: lacks-kern-info]
⚠ WARN: Combined length of family and style must not exceed 27 characters.
FONT_FAMILY_NAME = 'Russolo 10pt ExtraLight' / SUBFAMILY_NAME = 'Regular'
Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]
⚠ WARN: Checking Vertical Metric Linegaps.
com.google.fonts/check/linegaps
⚠ WARN OS/2 sTypoLineGap is not equal to 0. [code: OS/2]
Summary
Note: The following loglevels were omitted in this report:
Diff images: russolo_qa.zip
The text was updated successfully, but these errors were encountered: