Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified to work on 0.91.2 and added functionality #1
Modified to work on 0.91.2 and added functionality #1
Changes from 3 commits
af0a039
2a33695
4d8b74a
743e75b
2192bf5
dd6e0aa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Operation mode and away mode have no implementation. Using any of these options returns errors.
I'm not sure what operation mode is supposed to do, the HASS docs say "Operation mode to set temperature to. This defaults to current_operation mode if not set, or set incorrectly.", but isn't this already achieved by using the hold mode?
I'm also not able to set the hold mode at the moment, there is no option to select "home", "vacation", etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Operation mode I was looking into to switch schedules, but it's a little more difficult (I know how to activate them again, but there is your custom (or more?) schedule and the learning schedule. Not sure though like you state if using operation mode for that is the best.
Hold mode can be set but the way hass-climate seems to have this done is using service
climate.set_hold_mode
.On changing the support flags, good call - I shouldn't have left the partials in - but not sure either on the implementation.
Hold-mode - seems legit for home/vacation etc. - works using the service call
Operation-mode - was looking into (ab)using this for schedule on/of
Away-mode - the device supports it, but I recon me only having it put up it still needs to 'learn', the way the docs of plugwise state it they use geofencing on their app for this? (Not sure if I particularly like it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented these out until we have a decision on how to go from here (code is still in, but not advertising them)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One way could be to use 'presets' as 'operation_mode' so users can adjust it from the UI directly and either not bother about the schedules or move those as 'hold_mode'. The way I read the code-comments, code-issues and some on the forum is that hold_mode is about retaining temperature at a set (i.e. hold) point, therefor our presets of Anna would align on hold_mode, right? Question would (or can) be, how (or if) we want to bother with being on schedule or not.