Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap detection module #396

Merged
merged 19 commits into from Jul 25, 2018
Merged

Wrap detection module #396

merged 19 commits into from Jul 25, 2018

Conversation

akshay326
Copy link
Contributor

For now, will tell whether april tag is present in the image or not. Will add other features soon. Refer here for an Eclipse demo tutorial.

@akshay326
Copy link
Contributor Author

Depends on #395 to work

@akshay326
Copy link
Contributor Author

@fspindle Can you see why is the build failing for gcc? I'm unable to reproduce the error on my desktop.

@akshay326
Copy link
Contributor Author

@fspindle See the java equivalent of this apriltag detection demo here in this Eclipse project.

screenshot from 2018-07-10 12-15-05

@akshay326
Copy link
Contributor Author

@fspindle Are you able to run Eclipse project?

@fspindle
Copy link
Contributor

Good work.
I think that there is a small bug in VpDisplay::displayFrame() visible mainly on the blue arrow corresponding to the z-axis. To reproduce just use visp/tutorial/detection/tag/AprilTag.pgm image.
Using this AprilTag.pgm image I have also an extra blue line starting from the left-top corner (0,0).

@akshay326
Copy link
Contributor Author

Ok. I'll look into it

@akshay326
Copy link
Contributor Author

Strange. Do u know why ant install fails sometimes on appveyor? It shows network connectivity issue 😄

@fspindle
Copy link
Contributor

Yes, very strange that chocolatey fails to install ant.

@fspindle fspindle mentioned this pull request Jul 11, 2018
Closed
@akshay326 akshay326 closed this Jul 19, 2018
@akshay326 akshay326 reopened this Jul 19, 2018
@akshay326 akshay326 closed this Jul 19, 2018
@akshay326 akshay326 reopened this Jul 19, 2018
@akshay326
Copy link
Contributor Author

Minor JSON typo 😅

@akshay326
Copy link
Contributor Author

Depends on #411 for travis build

@akshay326
Copy link
Contributor Author

Its complete now. Ready for merging

s-trinh
s-trinh reviewed Jul 25, 2018
View reviewed changes
modules/java/generator/src/cpp/listconverters.cpp
return V;
}

jlongArray vector_vpHomogeneousMatrix_to_List(JNIEnv* env, std::vector<vpHomogeneousMatrix> V)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use std::vector<vpHomogeneousMatrix>& V to avoid a copy.

@s-trinh s-trinh merged commit 6355620 into lagadic:master Jul 25, 2018
@akshay326 akshay326 deleted the wrap_detection branch November 5, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-trinh s-trinh s-trinh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akshay326 @fspindle @s-trinh