Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt final week #23

Merged
merged 5 commits into from Aug 30, 2017
Merged

Qt final week #23

merged 5 commits into from Aug 30, 2017

Conversation

vikasTmz
Copy link
Contributor

@vikasTmz vikasTmz commented Aug 24, 2017

TODO:

  • Parse correctly generic CAO model (see here)
  • Save Qt3DRender::QCamera Settings into XML config file.
  • Display face normals.
  • Switch model points when the displayed face normal is not correct.
  • Choose the 3D points for the init config file.
  • Exporting Multiple models.
  • Fix bug: "run the application --> import CAO + save dialog make the application crash"
  • Update README/Documentation for Qt-App.
  • Remove unused icons.
  • Help button.
  • Get lod settings (length & area) using camera intrinsic & extrinsic properties & world coord.

@s-trinh
Copy link
Contributor

s-trinh commented Aug 26, 2017

Looks like in Qt3DRender::QObjectPicker *createObjectPickerForEntity(Qt3DCore::QEntity *entity); function signature, the returned pointer is not used. If so, you can remove the return.

The QObjectPicker in Qt3D seems still buggy in this Qt version (5.9.1)? I have some issues to correctly select the init point and not set the face properties. It works with some difficulties. I repaste your link for improvement / test in the future.

If you have some time at the end, some improvements:

  • there should be an option to change the sphere radius to select the init points
  • do not add the same init point if the user click multiple of times on the same sphere

@fspindle fspindle merged commit 63e1d59 into lagadic:master Aug 30, 2017
@vikasTmz
Copy link
Contributor Author

I was planning to finish some of these tasks before this branch got merged, or should I make a new PR?

@s-trinh
Copy link
Contributor

s-trinh commented Aug 30, 2017

You can just open another PR and add the corresponding link in the Wiki page.

@fspindle
Copy link
Contributor

Sorry, we did the merge before asking you.
I think that a new PR would be perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants