Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nyc --all flag #2

Closed
tonywoode opened this issue Jan 13, 2017 · 4 comments
Closed

Add support for nyc --all flag #2

tonywoode opened this issue Jan 13, 2017 · 4 comments

Comments

@tonywoode
Copy link

tonywoode commented Jan 13, 2017

nyc has the following flag
however mochista has its own --all flag, which has unrelated functionality
Are you planning to support the nyc --all flag?

@laggingreflex
Copy link
Owner

I might, but it's not a priority for me personally at the moment so I'll have to postpone it to the future. PR welcome though.

Right now the way it works is that it registers a require hook (hooks into all require calls) and thus it can only know about the files that are actually required. (related code: https://github.com/laggingreflex/mochista/blob/master/src/istanbul/instrument/index.js#L19)

Such a functionality will need to re-write whatever nyc does to include all files that aren't required by the testing (mocha) code.

@garex
Copy link

garex commented May 15, 2017

Currently nyc has --all flag in package.json, but as I understand, mochista not used any nyc settings.

Sad, but this is show stopper for me.

@laggingreflex
Copy link
Owner

laggingreflex commented May 28, 2017

Added. a2db9f2 7f8900d Released 0.12.2. Please check it out and let me know.

@garex
Copy link

garex commented May 28, 2017

@laggingreflex tnx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants