Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config defaults to code #188

Merged
merged 1 commit into from Mar 17, 2016
Merged

Added config defaults to code #188

merged 1 commit into from Mar 17, 2016

Conversation

david-caro
Copy link
Member

That way if we introduce a new conf value and the local conf file was
modified, an upgrade will not make lago throw 'missing key' error, but
get the default from the defaults in the code itself

Fixes #187

Change-Id: I9d20f91a3789a9068a0bafdecfb6e1e974219a01
Signed-off-by: David Caro dcaroest@redhat.com

@david-caro david-caro self-assigned this Mar 16, 2016
@david-caro david-caro added the bug label Mar 16, 2016
@david-caro
Copy link
Member Author

ci merge please

That way if we introduce a new conf value and the local conf file was
modified, an upgrade will not make lago throw 'missing key' error, but
get the default from the defaults in the code itself

Fixes #187

Change-Id: I9d20f91a3789a9068a0bafdecfb6e1e974219a01
Signed-off-by: David Caro <dcaroest@redhat.com>
@david-caro
Copy link
Member Author

this should not trigger ci test please

@david-caro
Copy link
Member Author

this should not trigger ci :shipit:

@david-caro
Copy link
Member Author

this should trigger
ci :shipit:

@david-caro
Copy link
Member Author

ci :shipit:
Maybe this instead

lago-bot added a commit that referenced this pull request Mar 17, 2016
@lago-bot lago-bot merged commit e70e4a6 into master Mar 17, 2016
@lago-bot lago-bot deleted the fix_conf_defaults branch March 17, 2016 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants