Add a function to get all the IPs of a VM #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we've started using multiple networks, it's nice to be able to get all IPs of a VM. Apparently, there's a strange scheme for the names: The first is <name>, the others are <name-ethX> . We should probably change it, but regardless, for now this allows getting all IPs.
|
ci test please |
|
@nvgoldin - can it get into 0.30, or should we wait for 0.31? |
|
@mykaul - can you rebase? |
|
ci merge please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've started using multiple networks, it's nice to be able to get all IPs of a VM.
Apparently, there's a strange scheme for the names:
The first is , the others are .
We should probably change it, but regardless, for now this allows getting all IPs.
Something like:
lago-basic-suite-master-engine: ips: [u'192.168.200.3', u'192.168.202.3']
And it'll be used in ovirt-system-tests later, something like:
def _get_host_all_ips(prefix, host_name):
return prefix.virt_env.get_vm(host_name).all_ips()