Expose environment configuration in LagomApplication

[solarmosaic-kflorence]

Lagom Version (1.2.x / 1.3.x / etc)

Current

API (Scala / Java / Neither / Both)

Scala

Expected Behavior

I would like to be able to reference environment configuration in additionalConfiguration.

Actual Behavior

Because the environment configuration is not loaded until after the additionalConfiguration, I have to load it myself with a redundant Configuration.load(environment). It would be nice to instead expose it on the LagomApplication, perhaps as a lazy val, so it can be referenced prior to additionalConfiguration being set.

[solarmosaic-kflorence]

Perhaps another way of achieving this would be to pass all available configuration into additionalConfiguration as an argument, like:

def additionalConfiguration(configuration: Configuration): AdditionalConfiguration = AdditionalConfiguration.empty

and

  override lazy val configuration: Configuration = {
    val currentConfiguration = Configuration.load(environment) ++ context.playContext.initialConfiguration
    val additionalConfig = new Configuration(additionalConfiguration(currentConfiguration).configuration)
    currentConfiguration ++ additionalConfig
  }

[octonato]

Thanks for reporting this.

I added this issue to the backlog, but it can take some time before someone can find time to pick it.

Would you be interested in sending a PR?

[solarmosaic-kflorence]

@renatocaval sure, I can submit a PR. I will try to do it on my non-work account sometime over the weekend (I have already signed the CLA there).