Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document CircuitBreaker #380

Closed
benmccann opened this issue Jan 17, 2017 · 2 comments
Closed

Document CircuitBreaker #380

benmccann opened this issue Jan 17, 2017 · 2 comments

Comments

@benmccann
Copy link
Contributor

CircuitBreaker appears to be a core concept of Lagom. I'm not familiar with the term in this context, so some brief description would be helpful.

The Javadoc doesn't say much right now: http://www.lagomframework.com/documentation/1.2.x/java/api/com/lightbend/lagom/javadsl/api/CircuitBreaker.html

@TimMoore
Copy link
Contributor

It's a good idea to improve the javadocs, but the concept and implementation in Lagom is also described in the reference guide at http://www.lagomframework.com/documentation/1.2.x/java/ServiceClients.html#circuit-breakers

@benmccann
Copy link
Contributor Author

Thanks! For some reason that page doesn't show up on the first page of Google when I search for lagom circuit breaker. The only reason that I can guess for that is that the javadocs are hosted on the same domain and rank higher and Google doesn't want to show too many results from the same domain.

I sent a PR to close this out: #385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants