Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka consumer offset #914

Merged
merged 1 commit into from
Aug 9, 2017
Merged

Kafka consumer offset #914

merged 1 commit into from
Aug 9, 2017

Conversation

octonato
Copy link
Member

@octonato octonato commented Aug 4, 2017

Resolves #907

@octonato octonato requested a review from TimMoore August 4, 2017 10:01
@octonato
Copy link
Member Author

octonato commented Aug 4, 2017

@TimMoore if I understand it right the only thing to do here is to move the property to the client module so both client and server can benefit from it. Was that all?

@TimMoore
Copy link
Contributor

TimMoore commented Aug 9, 2017

I think so!

@TimMoore TimMoore merged commit 16fdb79 into lagom:master Aug 9, 2017
@octonato octonato deleted the kafka-consumer-offset branch August 9, 2017 13:44
@ignasi35 ignasi35 added this to the Lagom 1.3.9 milestone Sep 4, 2017
ignasi35 pushed a commit that referenced this pull request Sep 4, 2017
@ignasi35
Move auto.offset.reset to Kafka client (#914)
693a495 
Fixes #907
@ignasi35
Copy link
Contributor

ignasi35 commented Sep 4, 2017

Long overdue backport: 1.3.x 693a495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimMoore TimMoore TimMoore approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
Lagom 1.3.9
Development

Successfully merging this pull request may close these issues.
3 participants
@octonato @TimMoore @ignasi35