-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove and doc unnecessary overrides (now added by default) #2008
Remove and doc unnecessary overrides (now added by default) #2008
Conversation
Despite #1922 being backported to |
In #2007 I dropped the suggestion to remove the override of the cluster sharding strategy as I think it's noise that detracts from the more critical information in the guide (e.g. cluster shutdown). So I suggest the same here (explicitly this time): if the configuration is just redundant but otherwise safe to have, I wouldn't include the detail on removing it. But I'm interested if anyone disagrees (maybe we can find a compromise). |
SGTM. Let me try again ;-) |
Actually, I'll rebase on top of #2007 to simplify future merges (fewer conflicts) |
24c1113
to
e4dbd52
Compare
Build failed on stalled execution and artifact download |
e4dbd52
to
b6d1fe3
Compare
@ignasi35 what do you think about removing the bindings from the Maven archetype only in 1.5.x? Less stuff to understand in a new Lagom 1.5 project, and less stuff to clean up when migrating. They were removed from the giter8 templates in lagom/lagom-java.g8#66 and lagom/lagom-scala.g8#66. |
Sure! I'm currently rewriting the g8 seeds and was planning on reworking the maven archetype but I only had |
related to #1922